Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update syncing status requirements in getHealth #341

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Update syncing status requirements in getHealth #341

merged 2 commits into from
Jul 25, 2023

Conversation

nflaig
Copy link
Collaborator

@nflaig nflaig commented Jul 23, 2023

While implementing syncing_status query parameter (#251), I noticed two issues with the current spec

  1. Schema allows invalid http status codes (1-99), this will cause problems for most http servers
  2. The API accepts user provided values but there is no error response for invalid values

@rolfyone
Copy link
Collaborator

Looks reasonable, I'll see if i can get some feedback on it, thanks!

@jimmygchen
Copy link
Contributor

Looks good 👍

@rolfyone rolfyone merged commit 11e5c27 into ethereum:master Jul 25, 2023
2 checks passed
@rolfyone rolfyone mentioned this pull request Jul 25, 2023
Closed
@Falehfale Falehfale mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nflaig @rolfyone @jimmygchen @dapplion